Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide an argument to set the maximum batch size for cuda graph #1809

Merged
merged 2 commits into from
Oct 26, 2024
Merged

Provide an argument to set the maximum batch size for cuda graph #1809

merged 2 commits into from
Oct 26, 2024
+25 −10

Conversation

merrymercy
Copy link
Contributor

@merrymercy merrymercy commented Oct 26, 2024 •
edited
Loading

  • Use --max-cuda-graph-bs 8 to limit the cuda graph max bs.
  • Rename SGLANG_CLIP_MAX_NEW_TOKENS to SGLANG_CLIP_MAX_NEW_TOKENS_ESTIMATION

@merrymercy merrymercy merged commit 2b80978 into main Oct 26, 2024
3 of 11 checks passed
@merrymercy merrymercy deleted the pr-cuda-graph branch October 26, 2024 22:09
qeternity pushed a commit to qeternity/sglang that referenced this pull request Oct 27, 2024
@merrymercy @qeternity
Provide an argument to set the maximum batch size for cuda graph (sgl…
3140e1e 
…-project#1809)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ying1123 Ying1123 Awaiting requested review from Ying1123 Ying1123 is a code owner

@hnyls2002 hnyls2002 Awaiting requested review from hnyls2002 hnyls2002 is a code owner

@zhyncs zhyncs Awaiting requested review from zhyncs zhyncs is a code owner

@ispobock ispobock Awaiting requested review from ispobock ispobock is a code owner

@ByronHsu ByronHsu Awaiting requested review from ByronHsu ByronHsu is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@merrymercy