Gate BIO_new_socket in OPENSSL_NO_SOCK in handwritten bindings #2002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You'll also need to add it here so we can discover the #define properly: https://github.com/sfackler/rust-openssl/blob/master/openssl-sys/build/expando.c |
OpenSSL conditions the availability of this symbol on OPENSSL_NO_SOCK. Match that in the handwritten bindings. This doesn't really matter as it's only in the handwritten bindings and not used by rust-openssl, but we may as well make it match OpenSSL.
done |
alex
approved these changes
Jul 24, 2023
sfackler
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenSSL conditions the availability of this symbol on
OPENSSL_NO_SOCK. Match that in the handwritten bindings.This doesn't really matter as it's only in the handwritten bindings and not used by rust-openssl, but we may as well make it match OpenSSL.