-
-
Notifications
You must be signed in to change notification settings - Fork 562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor options and add MaxArraySize constraint #923
Conversation
While implementing came up with couple questions, should this be |
c30a39e
to
e70d1c8
Compare
@sebastienros please take a look. |
@sebastienros any input? |
Bump requesting this get resolved |
e70d1c8
to
2d16bbb
Compare
2d16bbb
to
cee8f8c
Compare
Let's refine in later pull requests if needed, the groundwork is now done. |
Can I still approve? |
Thanks for the gesture 😄 You can still also list improvement ideas though! |
fixes #917
fixes #887
fixes #683