Some code review changes

sebastienros · Oct 24, 2024 · d2301a7 · d2301a7
1 parent 9fc2663
commit d2301a7
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 10 deletions.
diff --git a/Jint/Native/JsSet.cs b/Jint/Native/JsSet.cs
@@ -13,7 +13,7 @@ public sealed class JsSet : ObjectInstance
     {
     }
 
-    public JsSet(Engine engine, OrderedSet<JsValue> set) : base(engine)
+    internal JsSet(Engine engine, OrderedSet<JsValue> set) : base(engine)
     {
         _set = set;
         _prototype = _engine.Realm.Intrinsics.Set.PrototypeObject;
@@ -49,15 +49,13 @@ protected override bool TryGetProperty(JsValue property, [NotNullWhen(true)] out
 
     public void Add(JsValue value) => _set.Add(value);
 
-    public void Remove(JsValue value) => _set.Remove(value);
-
     public void Clear() => _set.Clear();
 
     public bool Has(JsValue key) => _set.Contains(key);
 
     public bool SetDelete(JsValue key) => _set.Remove(key);
 
-    public void ForEach(ICallable callable, JsValue thisArg)
+    internal void ForEach(ICallable callable, JsValue thisArg)
     {
         var args = _engine._jsValueArrayPool.RentArray(3);
         args[2] = this;
@@ -73,7 +71,7 @@ public void ForEach(ICallable callable, JsValue thisArg)
         _engine._jsValueArrayPool.ReturnArray(args);
     }
 
-    public ObjectInstance Entries() => _engine.Realm.Intrinsics.SetIteratorPrototype.ConstructEntryIterator(this);
+    internal ObjectInstance Entries() => _engine.Realm.Intrinsics.SetIteratorPrototype.ConstructEntryIterator(this);
 
-    public ObjectInstance Values() => _engine.Realm.Intrinsics.SetIteratorPrototype.ConstructValueIterator(this);
+    internal ObjectInstance Values() => _engine.Realm.Intrinsics.SetIteratorPrototype.ConstructValueIterator(this);
 }
diff --git a/Jint/Native/Set/SetPrototype.cs b/Jint/Native/Set/SetPrototype.cs
@@ -119,7 +119,7 @@ private JsSet Difference(JsValue thisObject, JsValue[] arguments)
                     var inOther = TypeConverter.ToBoolean(otherRec.Has.Call(otherRec.Set, args));
                     if (inOther)
                     {
-                        resultSetData.Remove(e);
+                        resultSetData.SetDelete(e);
                         index--;
                     }
                 }
@@ -144,7 +144,7 @@ private JsSet Difference(JsValue thisObject, JsValue[] arguments)
                 nextValue = JsNumber.PositiveZero;
             }
 
-            resultSetData.Remove(nextValue);
+            resultSetData.SetDelete(nextValue);
         }
 
         return resultSetData;
@@ -308,7 +308,7 @@ private JsSet SymmetricDifference(JsValue thisObject, JsValue[] arguments)
             {
                 if (inResult)
                 {
-                    resultSetData.Remove(nextValue);
+                    resultSetData.SetDelete(nextValue);
                 }
             }
             else

diff --git a/Jint/Runtime/OrderedSet.cs b/Jint/Runtime/OrderedSet.cs
@@ -1,6 +1,6 @@
 namespace Jint.Runtime;
 
-public sealed class OrderedSet<T>
+internal sealed class OrderedSet<T>
 {
     internal List<T> _list;
     internal HashSet<T> _set;