Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add create etcd cluster and weed cluster function #2304

Merged
merged 6 commits into from
Oct 31, 2023

Conversation

sjcsjc123
Copy link

Describe what this PR does / why we need it

Provide an interface to create a distributed file system and implement cluster mounting of rootfs

Does this pull request fix one issue?

NONE

Describe how you did it

Adopting decentralized weed cluster deployment method

  • create etcd cluster
  • start weed master
  • register weed master to etcd cluster
  • when upload or download, get service from etcd cluster

Describe how to verify it

At present, the testing has not been completed yet, and will be improved in the future.

Special notes for reviews

There is still a lot of unfinished work for this PR, and I will improve it as soon as possible and provide a functional test report.

  • Need to combine ssh to start the etcd node and the weed node
  • Need to consider whether to start the etcd cluster or weed cluster through k8s
  • There is currently an issue with the go dependency file. Please wait for local repairs before uploading the go mod file.

@github-actions github-actions bot added the test label Sep 26, 2023
@sjcsjc123 sjcsjc123 marked this pull request as draft September 26, 2023 18:19
@starnop
Copy link
Collaborator

starnop commented Oct 24, 2023

@sjcsjc123 Thanks for your great work, and cloud you please make the CI all passed before it can be reviewed.

@sjcsjc123
Copy link
Author

@sjcsjc123 Thanks for your great work, and cloud you please make the CI all passed before it can be reviewed.

I will fix it in a few days and improve the testing. I have some things to do in the past few days.

@codecov-commenter
Copy link

codecov-commenter commented Oct 26, 2023

Codecov Report

Attention: 741 lines in your changes are missing coverage. Please review.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Files Coverage Δ
utils/weed/check.go 0.00% <0.00%> (ø)
utils/weed/weed.go 0.00% <0.00%> (ø)
utils/weed/weed_volumn.go 0.00% <0.00%> (ø)
utils/weed/etcd_client.go 0.00% <0.00%> (ø)
utils/weed/weed_master.go 0.00% <0.00%> (ø)
utils/weed/etcd.go 0.00% <0.00%> (ø)
utils/weed/interface.go 0.00% <0.00%> (ø)

... and 173 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@github-actions github-actions bot added e2e-test it needs to run e2e test and removed e2e-test it needs to run e2e test labels Oct 26, 2023
@github-actions github-actions bot added e2e-test it needs to run e2e test and removed e2e-test it needs to run e2e test labels Oct 29, 2023
Signed-off-by: sjcsjc123 <1401189096@qq.com>
@sjcsjc123 sjcsjc123 force-pushed the rootfs branch 2 times, most recently from 7bf3a30 to 239ccd0 Compare October 30, 2023 02:39
@sjcsjc123 sjcsjc123 marked this pull request as ready for review October 30, 2023 05:44
@starnop
Copy link
Collaborator

starnop commented Oct 30, 2023

@sjcsjc123 please squash your commits firstly

And In addition, regarding the comment in the PR, you can refer to see if there are similar problems

image

@sjcsjc123
Copy link
Author

sjcsjc123 commented Oct 30, 2023

@starnop I got it. I will try to squash them.

This reverts commit b75e8a6.

Signed-off-by: sjcsjc123 <1401189096@qq.com>
Signed-off-by: sjcsjc123 <1401189096@qq.com>
Signed-off-by: sjcsjc123 <1401189096@qq.com>
Signed-off-by: sjcsjc123 <1401189096@qq.com>
@sjcsjc123 sjcsjc123 closed this Oct 30, 2023
@sjcsjc123 sjcsjc123 reopened this Oct 30, 2023
Signed-off-by: sjcsjc123 <1401189096@qq.com>
@maxwell-can-not-fly
Copy link
Collaborator

maxwell-can-not-fly commented Oct 31, 2023

I suggest following items to be done before going into release: 1. finish testing and provide test evidence on basic functions 2. integrate with NewImageMounter() method and provide a switch to enable it (use previous implementation by default, use new implantation if user tell us to) 3. squash all commits into one to maintain a clear commit history

@starnop starnop changed the base branch from main to alpha October 31, 2023 15:13
@maxwell-can-not-fly
Copy link
Collaborator

Going into alpha branch to meet SoC requirements, please see comment for follow up actions to be merge to main branch and next release.

@maxwell-can-not-fly maxwell-can-not-fly merged commit 59b6872 into sealerio:alpha Oct 31, 2023
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants