Add face for notifications (#431)

There is a face for the number part of notifications (`doom-modeline-unread-number`), however, none for the notification itself. For symmetry, we introduce `doom-modeline-notification` as a face for notifications. We also set the default value to `doom-modeline-warning` to keep the previous behavior. Signed-off-by: Waqar Hameed <whame91@gmail.com>
seagle0128 · Apr 12, 2021 · 3433275 · 3433275
1 parent 669cac3
commit 3433275
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 10 deletions.
diff --git a/doom-modeline-core.el b/doom-modeline-core.el
@@ -617,6 +617,12 @@ It requires `circe' or `erc' package."
   "Face for errors in the mode-line. Used by vcs, checker, etc."
   :group 'doom-modeline-faces)
 
+(defface doom-modeline-notification
+  '((t (:inherit doom-modeline-warning)))
+  "Face for notifications in the mode-line. Used by GitHub, mu4e,
+etc. (also see the face `doom-modeline-unread-number')."
+  :group 'doom-modeline-faces)
+
 (defface doom-modeline-unread-number
   '((t (:slant italic :weight normal)))
   "Face for unread number in the mode-line. Used by GitHub, mu4e, etc."

diff --git a/doom-modeline-segments.el b/doom-modeline-segments.el
@@ -2069,15 +2069,16 @@ Example:
      (propertize
       (concat
        (doom-modeline-icon 'faicon "github" "🔔" "#"
-                           :face 'doom-modeline-warning
+                           :face 'doom-modeline-notification
                            :v-adjust -0.0575)
        (doom-modeline-vspc)
        ;; GitHub API is paged, and the limit is 50
        (propertize
         (if (>= doom-modeline--github-notification-number 50)
             "50+"
           (number-to-string doom-modeline--github-notification-number))
-        'face '(:inherit (doom-modeline-unread-number doom-modeline-warning))))
+        'face '(:inherit
+                (doom-modeline-unread-number doom-modeline-notification))))
       'help-echo "Github Notifications
 mouse-1: Show notifications
 mouse-3: Fetch notifications"
@@ -2254,14 +2255,15 @@ mouse-1: Toggle Debug on Quit"
      (propertize
       (concat
        (doom-modeline-icon 'material "email" "📧" "#"
-                           :face 'doom-modeline-warning
+                           :face 'doom-modeline-notification
                            :height 1.1 :v-adjust -0.2)
        (doom-modeline-vspc)
        (propertize
         (if (> mu4e-alert-mode-line doom-modeline-number-limit)
             (format "%d+" doom-modeline-number-limit)
           (number-to-string mu4e-alert-mode-line))
-        'face '(:inherit (doom-modeline-unread-number doom-modeline-warning))))
+        'face '(:inherit
+                (doom-modeline-unread-number doom-modeline-notification))))
       'mouse-face 'mode-line-highlight
       'keymap '(mode-line keymap
                           (mouse-1 . mu4e-alert-view-unread-mails)
@@ -2352,14 +2354,15 @@ mouse-1: Toggle Debug on Quit"
      (propertize
       (concat
        (doom-modeline-icon 'material "email" "📧" "#"
-                           :face 'doom-modeline-warning
+                           :face 'doom-modeline-notification
                            :height 1.1 :v-adjust -0.2)
        (doom-modeline-vspc)
        (propertize
         (if (> doom-modeline--gnus-unread-mail doom-modeline-number-limit)
             (format "%d+" doom-modeline-number-limit)
           (number-to-string doom-modeline--gnus-unread-mail))
-        'face '(:inherit (doom-modeline-unread-number doom-modeline-warning))))
+        'face '(:inherit
+                (doom-modeline-unread-number doom-modeline-notification))))
       'mouse-face 'mode-line-highlight
       'help-echo (if (= doom-modeline--gnus-unread-mail 1)
                      "You have an unread email"
@@ -2393,7 +2396,7 @@ to be an icon and we don't want to remove that so we just return the original."
    (lambda (b)
      (propertize
       (doom-modeline--shorten-irc (funcall doom-modeline-irc-stylize b))
-      'face '(:inherit (doom-modeline-unread-number doom-modeline-warning))
+      'face '(:inherit (doom-modeline-unread-number doom-modeline-notification))
       'help-echo (format "IRC Notification: %s\nmouse-1: Switch to buffer" b)
       'mouse-face 'mode-line-highlight
       'local-map (make-mode-line-mouse-map 'mouse-1
@@ -2457,13 +2460,14 @@ to be an icon and we don't want to remove that so we just return the original."
 
          (propertize (concat
                       (doom-modeline-icon 'material "message" "🗊" "#"
-                                          :face 'doom-modeline-warning
+                                          :face 'doom-modeline-notification
                                           :height 1.0 :v-adjust -0.225)
                       (doom-modeline-vspc)
                       ;; Display the number of unread buffers
                       (propertize (number-to-string number)
-                                  'face '(:inherit (doom-modeline-unread-number
-                                                    doom-modeline-warning))))
+                                  'face '(:inherit
+                                          (doom-modeline-unread-number
+                                           doom-modeline-notification))))
                      'help-echo (format "IRC Notifications: %s\n%s"
                                         (mapconcat
                                          (lambda (b) (funcall doom-modeline-irc-stylize b))