call destructor in ComponentArray::erase()

sdslabs · Aug 24, 2023 · 2aac4d7 · 2aac4d7
1 parent e46a5ab
commit 2aac4d7
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/rootex/framework/component.h b/rootex/framework/component.h
@@ -134,7 +134,7 @@ class Component
 	/// Perform setting up operations which are possible only after all entities have been set up.
 	virtual bool setupEntities() { return true; }
 	/// Perform operations prior to detachment from owning entity and destruction.
-	virtual void onRemove() { this->~Component(); }
+	virtual void onRemove() { }
 
 	Entity& getOwner() { return *m_Owner; }
 	virtual ComponentID getComponentID() const = 0;

diff --git a/rootex/utility/component_array.h b/rootex/utility/component_array.h
@@ -92,6 +92,8 @@ class ComponentArray
 			{
 				m_IsValid[i] = false;
 				m_Data[i].onRemove();
+				m_Data[i].~Component();
+				memset(&m_Data[i], 0, sizeof(m_Data[i]));
 				m_ArraySize--;
 				return true;
 			}