Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix view behavior for AwkwardArrays #1070

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Fix view behavior for AwkwardArrays #1070

wants to merge 12 commits into from

Commits on Jul 24, 2023

  1. Configuration menu
    Copy the full SHA
    b23eda3 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2023

  1. Fix views of views

    grst committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    b640617 View commit details
    Browse the repository at this point in the history
  2. Update anndata/_core/views.py

    Co-authored-by: Angus Hollands <goosey15@gmail.com>
    grst and agoose77 authored Jul 25, 2023
    Configuration menu
    Copy the full SHA
    843833f View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2023

  1. Remove all custom code for views

    grst committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    8aa09cc View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2023

  1. WIP add test cases

    grst committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    86c5ff8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a01b80e View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    dfe7008 View commit details
    Browse the repository at this point in the history
  4. More test cases

    grst committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    8b14e57 View commit details
    Browse the repository at this point in the history
  5. Add comment about view behavior

    grst committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    4870553 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2023

  1. Configuration menu
    Copy the full SHA
    257c063 View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2023

  1. Fix akward array view test

    The test didn't catch that when modifying an awkward array in a
    AnnDataView, the changes did not persist within that view.
    
    The issue was that I had been retreiving the awkward array
    from the view once, and then did tests on it. Instead, to properly
    test this, I need to retreive the Awkward array from the AnnData view
    every time. It turns out doing so gives me a fresh copy of the origina
    awkward array and modifications only affect that copy - not the original data.
    grst committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    4b34598 View commit details
    Browse the repository at this point in the history
  2. Fix that awkward arrays in an awyward array view could not be modified.

    I solved the issue described in the previous commit by adding
    logic to `AlignedViewMixin` that can copy objects of a certain type
    (for now only awkward arrays) upon view creation.
    grst committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    fdeff90 View commit details
    Browse the repository at this point in the history