Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace old zkevm-prover with two-compression-layers prover #167

Merged
merged 12 commits into from
Jul 22, 2023

Conversation

silathdiir
Copy link
Contributor

@silathdiir silathdiir commented Jul 19, 2023

Separate compression-circuit related part of code from #160

Summary

  • Move new prover and verifier from aggregator folder to common.

  • Reuse new prover and verifier to implement zkevm-prover (for chunk prove) and inner-prover (for super circuit prove).

  • Replace compression_tests with chunk_tests.

  • Update to do both normal and EVM verifications in new chunk_tests.

  • Upgrade to latest develop branch of zkevm-circuits.

Test

  • make test-inner-prove could pass.
  • make test-chunk-prove could pass.

@silathdiir silathdiir requested a review from lispc July 19, 2023 08:54
@silathdiir silathdiir force-pushed the replace-old-chunk-prover-with-two-compressions branch from 4459840 to 93f8e1c Compare July 19, 2023 09:08
@lispc
Copy link
Collaborator

lispc commented Jul 19, 2023

(not high priority)

  1. how long this method takes usually? verifier.evm_verify::<CompressionCircuit>(&proof, &output_dir); ? and what about verifier.verify::<CompressionCircuit>(&proof)? We may verify both in tests?
  2. make test-inner-prove is useful. I run that test from time to time to ensure real proving of super circuit works well. That test is much faster than make test-comp-prove. So we need either (1) add back make test-inner-prove or (2) as a tmp solution, after snark/proof of super circuit generated, verify it either using verifier.verify or verifier.evm_verify and log::info success. Then from log i can know super circuit proving & verification succeeds.

@silathdiir silathdiir changed the title [WIP] Replace old zkevm-prover with two-compression-layers prover Replace old zkevm-prover with two-compression-layers prover Jul 22, 2023
@lispc
Copy link
Collaborator

lispc commented Jul 22, 2023

generally good.

@lispc lispc merged commit 6c84e25 into main Jul 22, 2023
3 checks passed
@lispc lispc deleted the replace-old-chunk-prover-with-two-compressions branch July 22, 2023 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants