Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a button for toggling the listening to keyboard input #17

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

henrikth93
Copy link
Member

This commit will add a button for toggling the listening of keyboard input. I am having some issues with the styling though

Contributor checklist


Description

This commit will add a button for toggling the listening of keyboard input.
Copy link

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Desktop rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First PR Commit Check

  • The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution
  • The contributor's name and icon in remote commits should be the same as what appears in the PR
  • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local Scribe-Desktop repo

@RyanPaulGannon
Copy link
Collaborator

RyanPaulGannon commented Oct 20, 2024

Hey! It's looking good, functionally all good. I have attached the docs for the styling, I can implement if you'd like, or you're welcome to push another commit?

If you've had the same difficulty as me regarding finding the styling docs, it's because iced appears to have changed the traits on the most recent version, so the linked docs are for 0.12.1 which still has the StyleSheet trait available - hope this helps :)

@henrikth93
Copy link
Member Author

Hey! It's looking good, functionally all good. I have attached the docs for the styling, I can implement if you'd like, or you're welcome to push another commit?

If you've had the same difficulty as me regarding finding the styling docs, it's because iced appears to have changed the traits on the most recent version, so the linked docs are for 0.12.1 which still has the StyleSheet trait available - hope this helps :)

Thank you! I will take a look at it if you have not already! :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants