Convert camel case to snake case #486
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added camel_to_snake function to convert camelCase keys and column headers to snake_case for consistency - Updated key and column name handling in convert_to_csv_or_tsv and convert_to_json functions
- Updated the create_table function to convert column names from camelCase to snake_case before creating the SQLite table. - Included a new import for the camel_to_snake function to handle the conversion.
Thank you for the pull request!The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you! Maintainer checklist |
- Added the camel_to_snake function to the utils.py file to avoid circular import issues. - Updated the import statements in data_to_sqlite.py and convert.py to reference the new location of the function. - Verified that all tests pass successfully after the changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor checklist
pytestcommand as directed in the testing section of the contributing guideDescription
This PR refactors the Scribe-Data export functionality to ensure consistency in key naming conventions by converting all camelCase JSON keys, CSV/TSV column headers, and SQLite columns to snake_case. This change improves alignment with common conventions for JSON and database formatting.
Changes Made
camel_to_snakehelper function to convert camelCase strings to snake_case.convert_to_jsonfunction to apply the new naming convention to JSON keys.convert_to_csv_or_tsvfunction to apply snake_case conversion to column headers in CSV/TSV exports.create_tablefunction to snake_case when creating SQLite tables.Related issue