Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format export keys for JSON and SQLite #312

Open
2 tasks done
andrewtavis opened this issue Oct 10, 2024 · 11 comments
Open
2 tasks done

Format export keys for JSON and SQLite #312

andrewtavis opened this issue Oct 10, 2024 · 11 comments
Assignees
Labels
feature New feature or request hacktoberfest Included as a part of Hacktoberfest help wanted Extra attention is needed

Comments

@andrewtavis
Copy link
Member

Terms

Description

As of now Scribe-Data export JSON keys and SQLite columns that are camelCase. Ideally these would all be snake_case as this is a bit more in line with expectations for JSON and database column formatting - snake_case works for both, and we should choose one.

We should wait on this issue so that the convert functionality isn't effected by it.

Contribution

CC @OmarAI2003 who had interest in this :) Happy to review and assist as needed!

@andrewtavis andrewtavis added feature New feature or request help wanted Extra attention is needed blocked Another issue is blocking hacktoberfest Included as a part of Hacktoberfest labels Oct 10, 2024
@andrewtavis
Copy link
Member Author

Feel free to write in here and I'll assign, @OmarAI2003 :)

@OmarAI2003
Copy link
Contributor

Feel free to write in here and I'll assign, @OmarAI2003 :)

Fine Andrew I'll investigate this tomorrow

@OmarAI2003
Copy link
Contributor

So this issue is no longer blocked, right?

@andrewtavis
Copy link
Member Author

Is not blocked, no

@andrewtavis andrewtavis removed the blocked Another issue is blocking label Oct 25, 2024
@OmarAI2003
Copy link
Contributor

OmarAI2003 commented Oct 25, 2024

@andrewtavis Should I change the tsv and csv column headers too?

@andrewtavis
Copy link
Member Author

Ideally yes :)

@andrewtavis
Copy link
Member Author

Thanks, @OmarAI2003! 😊

@OmarAI2003
Copy link
Contributor

Ideally yes :)

Done. But sadly some tests failed.

@andrewtavis
Copy link
Member Author

Let me know if you need me to take a look :)

@OmarAI2003
Copy link
Contributor

Alright. I will.

@OmarAI2003
Copy link
Contributor

@andrewtavis Everything is fixed now! 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request hacktoberfest Included as a part of Hacktoberfest help wanted Extra attention is needed
Projects
Status: Todo
Development

No branches or pull requests

2 participants