Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to installation icon size and menu control #199

Merged

Conversation

MostafaMohamed2002
Copy link
Contributor

@MostafaMohamed2002 MostafaMohamed2002 commented Oct 15, 2024

Contributor checklist


Description

this is what it looks like after change the icon size and aligned it with text
image

Related issue

Copy link

github-actions bot commented Oct 15, 2024

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Android rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The linting and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@andrewtavis andrewtavis added the hacktoberfest-accepted Accepted as a part of Hacktoberfest label Oct 15, 2024
@andrewtavis andrewtavis self-requested a review October 15, 2024 12:56
@andrewtavis
Copy link
Member

Hey @MostafaMohamed2002 👋 For me the entire area still isn't clickable, which might not be clear :) Even if we click the gear icon it'd still be good to go to the keyboard settings, so it's a bit more of a refactor :)

@MostafaMohamed2002
Copy link
Contributor Author

Hey @MostafaMohamed2002 👋 For me the entire area still isn't clickable, which might not be clear :) Even if we click the gear icon it'd still be good to go to the keyboard settings, so it's a bit more of a refactor :)

so should i make the whole box clickable or just the gear icon ?

@andrewtavis
Copy link
Member

The whole box :) Ideally the Open keyboard settings would also be underlined as it is in the designs, but we can do an issue for that later.

Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for this, @MostafaMohamed2002! Great to have the installation screen up to these standards already 😊

@andrewtavis andrewtavis merged commit 0314f76 into scribe-org:main Oct 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Accepted as a part of Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants