Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move docker recipe to documentation along with instructions. #100

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

YooSunYoung
Copy link
Member

Fixes #99

I removed docker yaml file for kafka and moved the information into the proper documentation under getting-started section.

It also has explanation why it is not included in the hard-dependencies.

@YooSunYoung
Copy link
Member Author

Here is the locally built documentation!
html.zip

@jokasimr
Copy link
Contributor

Looks good to me.

Makes sense to exclude Kafka from the dependencies and put the setup instructions in the documentation instead if Kafka is not the only supported message delivery framework.

Are the Kafka tests run in the CI pipeline? I'm thinking that it is probably good to run them somewhere on a regular basis.

How was the 6GB limit selected?
Do we exceed that limit if we run the benchmark for a longer time period?

@YooSunYoung
Copy link
Member Author

Are the Kafka tests run in the CI pipeline? I'm thinking that it is probably good to run them somewhere on a regular basis.

Not yet, but yes we do need an automated tests. There's an issue regarding this. #97

How was the 6GB limit selected?
Do we exceed that limit if we run the benchmark for a longer time period?

This number was given by ECDC so I think they have tested it within their testing environment.

@YooSunYoung YooSunYoung merged commit a142a7b into main Oct 12, 2023
3 checks passed
@YooSunYoung YooSunYoung deleted the documentation-kafka branch October 16, 2023 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kafka integration test, broker buffer memory error.
2 participants