-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update versioning #219
Update versioning #219
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #219 +/- ##
=======================================
Coverage 99.85% 99.85%
=======================================
Files 15 15
Lines 1335 1367 +32
=======================================
+ Hits 1333 1365 +32
Misses 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good, we should keep an eye on Python 3,13 over the medium term
Description
Drop support for python 3.7 and use importlib instead of setuptools to get package versions.
importlib.metadata
was 'provisional' in 3.8 and 3.9, but given that it was then made non-provisional without substantial changes in 3.10, this seems safe enough.Checklist
[ ] All new functions and classes are documented and adhere to Google doc style (3.8.3-3.8.6 of this document)[ ] Add/update sphinx documentation with any relevant changes.[ ] Add/update pytest-style tests in/tests
, ensuring sufficient code coverage.make test
runs without errors.make lint
doesn't give any warnings.make format
doesn't give any code formatting suggestions.make doc
runs without errors and generated docs render correctly.Resolves #215