Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update versioning #219

Merged
merged 8 commits into from
Oct 10, 2024
Merged

Update versioning #219

merged 8 commits into from
Oct 10, 2024

Conversation

cnweaver
Copy link
Contributor

@cnweaver cnweaver commented Oct 9, 2024

Description

Drop support for python 3.7 and use importlib instead of setuptools to get package versions. importlib.metadata was 'provisional' in 3.8 and 3.9, but given that it was then made non-provisional without substantial changes in 3.10, this seems safe enough.

Checklist

  • [ ] All new functions and classes are documented and adhere to Google doc style (3.8.3-3.8.6 of this document)
  • [ ] Add/update sphinx documentation with any relevant changes.
  • [ ] Add/update pytest-style tests in /tests, ensuring sufficient code coverage.
  • make test runs without errors.
  • make lint doesn't give any warnings.
  • make format doesn't give any code formatting suggestions.
  • make doc runs without errors and generated docs render correctly.
  • Check that CI pipeline run on this PR passes all stages.
  • Review signoff by at least one developer.

Resolves #215

@cnweaver cnweaver added the enhancement New feature or request label Oct 9, 2024
@cnweaver cnweaver self-assigned this Oct 9, 2024
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.85%. Comparing base (ca3fff4) to head (3e31419).
Report is 8 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #219   +/-   ##
=======================================
  Coverage   99.85%   99.85%           
=======================================
  Files          15       15           
  Lines        1335     1367   +32     
=======================================
+ Hits         1333     1365   +32     
  Misses          2        2           
Flag Coverage Δ
pytest 99.85% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@adambrazier adambrazier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, we should keep an eye on Python 3,13 over the medium term

@cnweaver cnweaver merged commit ae629e5 into master Oct 10, 2024
9 checks passed
@cnweaver cnweaver deleted the update-versioning branch October 10, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revisit reporting package versions
2 participants