Add explicit setuptools dependency #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #216 +/- ##
=======================================
Coverage 99.85% 99.85%
=======================================
Files 15 15
Lines 1335 1335
=======================================
Hits 1333 1333
Misses 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
adambrazier
approved these changes
Sep 23, 2024
There was a problem hiding this comment.
All good; a simple addition of setuptools as a requirement resulting from testing by @cnweaver and myself of the necessity of it for the Python3.12 installation of hop-client
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a short-term fix for the concerns in #215 .
Checklist
[ ] All new functions and classes are documented and adhere to Google doc style (3.8.3-3.8.6 of this document)[ ] Add/update sphinx documentation with any relevant changes.[ ] Add/update pytest-style tests in/tests, ensuring sufficient code coverage.make testruns without errors.make lintdoesn't give any warnings.make formatdoesn't give any code formatting suggestions.make docruns without errors and generated docs render correctly.