Expose the capability to multiple topics #211
Conversation
| if len(topics) != 1: | ||
| raise ValueError("must specify exactly one topic in write mode") | ||
| if topics is None or len(topics) != 1: | ||
| topics = [None] |
There was a problem hiding this comment.
Is the idea here that if they set multiple topics, you set the topic to None in the Producer so they are forced to manually enter topic in subsequent write calls so there is no ambiguity?
There was a problem hiding this comment.
Exactly; the choice we made at the adc level was to store only one topic (https://github.com/astronomy-commons/adc-streaming/blob/b1a5a81c52d2752a9fd63b9717c121285646d09b/adc/producer.py#L89), as either there is a specific topic to which the user wants to always publish or they will have to specify it with ever write, and there didn't seem to be much point in artificially restricting the caller in that latter case to one of the predeclared topics, so we just forget what topics they specified except that there was not exactly one.
Description
Based on astronomy-commons/adc-streaming#69 , this exposes the same functionality through the hop API.
Checklist
/tests, ensuring sufficient code coverage.make testruns without errors.make lintdoesn't give any warnings.make formatdoesn't give any code formatting suggestions.make docruns without errors and generated docs render correctly.