-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG+1] Threshold for pairs learners #168
Merged
bellet
merged 43 commits into
scikit-learn-contrib:master
from
wdevazelhes:feat/add_threshold
Apr 15, 2019
Merged
Changes from 33 commits
Commits
Show all changes
43 commits
Select commit
Hold shift + click to select a range
676ab86
add some tests for testing that different scores work using the scori…
cc1c3e6
ENH: Add tests and basic threshold implementation
f95c456
Add support for LSML and more generally quadruplets
9ffe8f7
Make CalibratedClassifierCV work (for preprocessor case) thanks to cl…
3354fb1
Fix some tests and PEP8 errors
12cb5f1
change the sign in decision function
dd8113e
Add docstring for threshold_ and classes_ in the base _PairsClassifie…
1c8cd29
remove quadruplets from the test with scikit learn custom scorings
d12729a
Remove argument y in quadruplets learners and lsml
dc9e21d
FIX fix docstrings of decision functions
402729f
FIX the threshold by taking the opposite (to be adapted to the decisi…
aaac3de
Fix tests to have no y for quadruplets' estimator fit
e5b1e47
Remove isin to be compatible with old numpy versions
a0cb3ca
Fix threshold so that it has a positive value and add small test
8d5fc50
Fix threshold for itml
0f14b25
FEAT: Add calibrate_threshold and tests
a6458a2
MAINT: remove starred syntax for compatibility with older versions of…
fada5cc
Remove debugging prints and make tests for ITML pass, while waiting f…
32a4889
FIX: from __future__ import division to pass tests for python 2.7
5cf71b9
Add some documentation for calibration
c2bc693
DOC: fix style
e96ee00
Merge branch 'master' into feat/add_threshold
3ed3430
Address most comments from aurelien's reviews
69c6945
Remove classes_ attribute and test for CalibratedClassifierCV
bc39392
Rename make_args_inc_quadruplets into remove_y_quadruplets
facc546
TST: Fix remaining threshold into min_rate
f0ca65e
Remove default_threshold and put calibrate_threshold instead
a6ec283
Use calibrate_threshold for ITML, and remove description
49fbbd7
ENH: use calibrate_threshold by default and display its parameters fr…
960b174
Add a small test to test automatic calibration
c91acf7
Update documentation of the default threshold
a742186
Inverse sense for threshold comparison to be more intuitive
9ec1ead
Address remaining review comments
986fed3
MAINT: Rename threshold_params into calibration_params
3f5d6d1
TST: Add test for extreme cases
7b5e4dd
MAINT: rename threshold_params into calibration_params
a3ec02c
MAINT: rename threshold_params into calibration_params
ccc66eb
FIX: Make tests work, and add the right threshold (mean between lowes…
6dff15b
Merge branch 'master' into feat/add_threshold
719d018
Go back to previous version of finding the threshold
551d161
Extract method for validating calibration parameters
594c485
Validate calibration params before fit
14713c6
Address https://github.com/metric-learn/metric-learn/pull/168#discuss…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
later (when fixing #173) this could be a good place for short note on the use of CalibratedClassifierCV
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree