Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Y24-372 - Correct country of origin values for submissions #4433

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

BenTopping
Copy link
Contributor

@BenTopping BenTopping commented Oct 18, 2024

Closes #4405

Changes proposed in this pull request

  • Sets Indsc::Country not applicable: control sample and not applicable: sample group to be invalid.
    • This means they will not appear in new manifests as options but does not prevent existing manifests with these types to be uploaded.
  • Creates Indsc::Country missing: control sample and missing: sample group

Instructions for Reviewers

There is another story to migrate existing data. However this story ensures all new manifests will only have the valid countries visible whilst also allowing existing manifests to use the old/invalid countries so as not break any behaviour.

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.57%. Comparing base (f107b9f) to head (f2791aa).
Report is 20 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4433      +/-   ##
===========================================
+ Coverage    86.55%   86.57%   +0.02%     
===========================================
  Files         1394     1394              
  Lines        29867    29946      +79     
===========================================
+ Hits         25851    25926      +75     
- Misses        4016     4020       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BenTopping BenTopping marked this pull request as ready for review October 21, 2024 08:08
@neilsycamore
Copy link
Contributor

ok

@BenTopping BenTopping reopened this Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Y24-372 - [BUG] incorrect country_of_origin options
2 participants