fix: allow pools to not be defined without raising exceptions

[StephenHulme]

Allow pools to not be defined without breaking all javascript in the page: user errors should not cause syntax errors.

Changes proposed in this pull request

• stop processing JS if pool is undefined or empty-string

Instructions for Reviewers

[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to main]
    - Check story numbers included
    - Check for debug code
    - Check version

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 77.95%. Comparing base (40ef006) to head (60b4bba).
Report is 3 commits behind head on develop.

Files with missing lines	Patch %	Lines
app/frontend/javascript/legacy_scripts_a.js	0.00%	4 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #2005      +/-   ##
===========================================
- Coverage    77.97%   77.95%   -0.02%     
===========================================
  Files          463      463              
  Lines        17708    17711       +3     
  Branches       225      225              
===========================================
  Hits         13807    13807              
- Misses        3899     3902       +3     
  Partials         2        2              

Flag	Coverage Δ
javascript	69.66% <0.00%> (-0.02%)	⬇️
pull_request	77.95% <0.00%> (-0.02%)	⬇️
push	77.95% <0.00%> (-0.02%)	⬇️
ruby	91.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[StephenHulme]

Stalled as this should ideally be tested against the real-life scenario before merging in - maybe it can be deployed to training?

[codeclimate]

Code Climate has analyzed commit 60b4bba and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 91.1% (0.0% change).

View more on Code Climate.

[StephenHulme]

Tested successfully in training comparing against uat.