Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: filter by pipeline or group when clicking on an edge in pipeline-graph #1999

Merged

Conversation

StephenHulme
Copy link
Contributor

Closes bug where clicking a pipeline in pipeline-group-mode filtered by undefined instead of the pipeline-group name

Changes proposed in this pull request

  • filter by pipeline or group when clicking on an edge

Instructions for Reviewers

[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to main]
    - Check story numbers included
    - Check for debug code
    - Check version

@StephenHulme StephenHulme added the Bug Bug in code label Oct 16, 2024
@StephenHulme StephenHulme self-assigned this Oct 16, 2024
Copy link

codeclimate bot commented Oct 16, 2024

Code Climate has analyzed commit 32ff150 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 91.1% (0.0% change).

View more on Code Climate.

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 77.97%. Comparing base (1c5d060) to head (32ff150).

Files with missing lines Patch % Lines
app/frontend/javascript/pipeline-graph/index.js 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1999      +/-   ##
===========================================
- Coverage    77.97%   77.97%   -0.01%     
===========================================
  Files          463      463              
  Lines        17706    17708       +2     
  Branches       225      225              
===========================================
  Hits         13807    13807              
- Misses        3897     3899       +2     
  Partials         2        2              
Flag Coverage Δ
javascript 69.68% <0.00%> (-0.02%) ⬇️
pull_request 77.97% <0.00%> (-0.01%) ⬇️
push 77.97% <0.00%> (-0.01%) ⬇️
ruby 91.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@StephenHulme StephenHulme merged commit f1b6287 into develop Oct 17, 2024
13 of 15 checks passed
@StephenHulme StephenHulme deleted the sh51/fix-pipelines-graph-undefined-on-click-bug branch October 17, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Bug in code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant