Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[automated] Merge Develop into Master #1940

Merged
merged 95 commits into from
Sep 20, 2024
Merged

[automated] Merge Develop into Master #1940

merged 95 commits into from
Sep 20, 2024

Conversation

Only just found out about it and it looks like it hasn't been done by anyone in recent times.
It's used by sub-classes so they need to be fixed first
…mium-pipelines

Y24-190-2: Use SS API v2 for barcode printers
yoldas and others added 2 commits September 18, 2024 21:21
…-to-lcmt-em-lib-pcr-config

Add TSISC_UDI96 and TSRNAhWGS_UDI96 to LCMT EM Lib PCR config
…ch-4.0.8

build(deps): bump micromatch from 4.0.5 to 4.0.8
@harrietc52
Copy link
Contributor

Nice :D

@StephenHulme StephenHulme changed the title Merge Develop into Master [Automated] Merge Develop into Master Sep 19, 2024
@StephenHulme StephenHulme changed the title [Automated] Merge Develop into Master [automated] Merge Develop into Master Sep 19, 2024
@StephenHulme
Copy link
Contributor

@sdjmchattie is #1884 a breaking change? Or will that be a subsequent v1 api removal?

@sdjmchattie
Copy link
Contributor

@sdjmchattie is #1884 a breaking change? Or will that be a subsequent v1 api removal?

Not sure what you're asking. I tested this works in UAT yesterday and I would like to see it go out to production 😁

@StephenHulme
Copy link
Contributor

Essentially, do we need a major version bump

@sdjmchattie
Copy link
Contributor

Essentially, do we need a major version bump

Oh I see. No it's essentially a refactor. No visible change to the end user.

@sdjmchattie
Copy link
Contributor

I haven't checked everything here. Mostly did a spot check that my changes look correctly included.

@StephenHulme StephenHulme merged commit dac2eb4 into master Sep 20, 2024
16 checks passed
Copy link
Member

@yoldas yoldas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version is incremented and all look OK for going to production.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants