Y24-190-3: Use SpecificTubeCreation on API v2 #1916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
app/sequencescape/sequencescape/api/v2/specific_tube_creation.rb
Outdated
Show resolved
Hide resolved
andrewsparkes
approved these changes
Sep 17, 2024
sdjmchattie
requested review from
andrewsparkes,
yoldas,
BenTopping and
StephenHulme
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop-Y24-190 #1916 +/- ##
================================================
Coverage 77.96% 77.97%
================================================
Files 459 460 +1
Lines 17688 17694 +6
Branches 229 229
================================================
+ Hits 13791 13797 +6
Misses 3895 3895
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…ion-on-api-v2 # Conflicts: # spec/models/labware_creators/plate_split_to_tube_racks_spec.rb
StephenHulme
approved these changes
Sep 18, 2024
sdjmchattie
deleted the
Y24-190-3-use-specific-tube-creation-on-api-v2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1818
Changes proposed in this pull request
Instructions for Reviewers
[All PRs] - Confirm PR template filled
[Feature Branches] - Review code