Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to hide certificate in the editbox #4284

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

love-code-yeyixiao
Copy link
Contributor

I Intolerance that the location of the certificates in the global settings was too easy to leak when the screen was shared, so I made the commit.

@love-code-yeyixiao love-code-yeyixiao marked this pull request as ready for review October 26, 2024 11:53
Comment on lines +9 to +11
### Added
- added the ability to hide certificates in editbox in Global Setting

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not under 1.15.1 / 5.70.1, which has already been released.

@isaak654 isaak654 marked this pull request as draft October 31, 2024 17:48
@DavidXanatos
Copy link
Member

What is to be protected the functionality of the cert or the name itself?
I would may be preffer to colals the edit box and expand it with a link as its done for the serial entry line edit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants