Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a second-auth feature in SbieStart #4062

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

love-code-yeyixiao
Copy link
Contributor

@love-code-yeyixiao love-code-yeyixiao commented Jul 7, 2024

The purpose of this pull request is to provide an option to allow Start.exe to not just use the system's own UAC popup when attempting to start a programme that requires administrator privileges,
but at the same time ask for the administrator account's credentials (which at this stage is also the password) again by us.

@offhub
Copy link
Collaborator

offhub commented Jul 7, 2024

Does this implementation support Windows Hello (like PIN)?

https://learn.microsoft.com/en-us/windows/win32/api/wincred/nf-wincred-creduipromptforwindowscredentialsw

@love-code-yeyixiao love-code-yeyixiao marked this pull request as draft July 7, 2024 13:40
@love-code-yeyixiao
Copy link
Contributor Author

If we use creduipromptforwindowscredentialsw,then we can do that,but it seems that we won't be able to vertify the truth of input,because we can't call LogonUser with a PIN blob,and there is no funcation like CredUiConifrom for creduipromptforwindowscredentialsw.So we have to use creduipromptforcredentialsa

@love-code-yeyixiao love-code-yeyixiao changed the title Start Add a second-auth feature in SbieStart Jul 28, 2024
@isaak654 isaak654 added the Status: Work in Progress Still in progress label Jul 30, 2024
@love-code-yeyixiao love-code-yeyixiao marked this pull request as ready for review October 26, 2024 15:04
@love-code-yeyixiao
Copy link
Contributor Author

Please review it. @DavidXanatos

@isaak654 isaak654 removed the Status: Work in Progress Still in progress label Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants