Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Node engine, Volta versions #43

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

khawkins
Copy link
Collaborator

@khawkins khawkins commented Sep 7, 2023

Volta does not support version ranges on pinning, so using Volta with the previous >=18 version was actually breaking for Volta installations.

Moved our Node engine minimum version to the engines configuration, and pinned Node 18 for Volta at the latest version.

@khawkins khawkins requested a review from a team as a code owner September 7, 2023 22:48
Copy link
Contributor

@sfdctaka sfdctaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@khawkins khawkins merged commit 7b91c40 into salesforce:main Sep 8, 2023
8 checks passed
@khawkins khawkins deleted the fix_project branch September 8, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants