feat(template-compiler): warning for slot attribute not at the top level #4711
+265
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cardoso
force-pushed
the
slot-top-level-warning
branch
3 times, most recently
from
2796e28
to
3d7769a
Compare
cardoso
force-pushed
the
slot-top-level-warning
branch
from
3d7769a
to
62d5634
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Rough implementation for now to discuss. Leaving as draft.
TODO:
Closes #4703
Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?
A new warning when compiling a template with an element that has a slot attribute which is likely to be ignored.
GUS work item