chore(tests): use built-in snapshot matcher for fixtures #4710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cardoso
commented
Oct 25, 2024
Comment on lines
+136
to
+148
| try { | ||
| if (content === undefined) { | ||
| expect(fs.existsSync(outputPath)).toBe(false); | ||
| } else { | ||
| await expect(content).toMatchFileSnapshot(outputPath); | ||
| } | ||
| } catch (err) { | ||
| if (typeof err === 'object' && err !== null) { | ||
| Error.captureStackTrace(err, testFixtureDir); | ||
| } | ||
|
|
||
| throw err; | ||
| } |
There was a problem hiding this comment.
If the content is undefined, toMatchFileSnapshot would create a file with the undefined as its content, so we check if the file doesn't exist instead.
Catching the error and capturing the stack trace makes sure the failure will be reported in the spec file instead of test-fixture-dir.ts .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Improves the experience a bit.
Before
After
Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?
GUS work item