-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suppress findings when conditions exist, except when --flag-all-risky-actions
flag is included
#303
Conversation
@jacobappleton-orbis - it looks like you ran the formatter across the code base. It's hard to read which parts of the PR actually changed the code vs. what was the formatter. Can you revert the files that are formatting related so I can just review the ones that introduce changes? Thanks :) |
3f66f72
to
c5995e2
Compare
Thanks for the contribution! Unfortunately we can't verify the commit author(s): Dan Jacobson <d***@o***.com>. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, sign the Salesforce Inc. Contributor License Agreement and this Pull Request will be revalidated. |
c5995e2
to
3d6d46e
Compare
@kmcquade I have removed the commit that performed the formatting. It appears that salesforce-cla bot now thinks that I have not signed the CLA, when I definitely have. Otherwise this should be in a good state now. |
cf5a0d1
to
50da3be
Compare
50da3be
to
04d74f1
Compare
Ok, I think I've fixed the CLA issue as well. |
@jacobappleton-orbis unit tests and NodeJS tests look good. But looks like it's failing the mypy check. If you can make that fix, then happy to merge. Thanks! |
--flag-all-risky-actions
flag is included
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I took the liberty and fixed the tiny type hint issue and since @kmcquade already gave his ok, so will I 😄
What does this PR do?
--flag-all-risky-actions
switch is set--flag-all-risky-actions
switch is now available to all scanning commands:scan
,scan-multi-account
, andscan-policy-file
What gif best describes this PR or how it makes you feel?
Completion checklist
make test
,make lint
,make security-test
,make test-js
)[ ] If the UI contents or JavaScript files have been modified, generate a new example report: