-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement Typography component #96
Conversation
Test Result
|
style, | ||
...rest | ||
}: TypographyProps): JSX.Element => { | ||
const styles = typographyVariantStyles[variant] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update the name to const variantStyles = typographyVariantStyles[variant]
to distinguish between other styles, Because styles, style, ...
is quite similar, so not easy to know which is the variant style, which is the text style at the first look unless we go to the styles definition.
Just a tiny suggestion. it's up to you
Summary
Create new component: Typography
Check List
Proof of Completeness