fix: include RDATE in busy calculation #691
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
SebastianKrupinski
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #691 +/- ##
============================================
- Coverage 98.76% 98.76% -0.01%
Complexity 1876 1876
============================================
Files 71 71
Lines 5346 5344 -2
============================================
- Hits 5280 5278 -2
Misses 66 66 ☔ View full report in Codecov by Sentry. |
|
@SebastianKrupinski can you add some unit test case(s) that demonstrate that RDATE specifications will now be correctly processed. |
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
phil-davis
force-pushed
the
fix-include-rdate-in-busy-calulation
branch
from
32f05b5
to
7081a17
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: include RDATE in busy calculation
ICal spec allows for events with only an RDATE. At the moment if an event only includes an RDATE and no RRULE it is skipped due to the current code path only checking for the existence of a RRULE.
RFC Reference https://datatracker.ietf.org/doc/html/rfc5545#section-3.8.5.2