Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for string-type parameter VALUE #640

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

phil-davis
Copy link
Contributor

Rebase of #636

Copy link

codecov bot commented Feb 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.78%. Comparing base (a2f05dd) to head (68d7d9b).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #640   +/-   ##
=========================================
  Coverage     98.78%   98.78%           
- Complexity     1875     1877    +2     
=========================================
  Files            71       71           
  Lines          5270     5273    +3     
=========================================
+ Hits           5206     5209    +3     
  Misses           64       64           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@phil-davis
Copy link
Contributor Author

CI passes, so existing test cases are still OK.

Need a response to #636 (comment) to be able to add a useful extra unit test case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants