Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: restructure with lockup dir #12

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

andreivladbrg
Copy link
Member

Closes #10

Important

The merge of this PR should be synchronized with renaming this repo to deployments (removing "V2") and updating the documentation in places such as this

Copy link
Member

@smol-ninja smol-ninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renaming this repo to deployment can be synchronised with renaming v2-core to lockup. So, feel free to merge this and open another issue about renaming repo.

@andreivladbrg
Copy link
Member Author

So, feel free to merge this and open another issue about renaming repo.

we need to also update the hyperlinks in docs

@smol-ninja
Copy link
Member

smol-ninja commented Oct 9, 2024

Right. So should we mark it as draft then to prevent accidental merging of this PR

@andreivladbrg
Copy link
Member Author

Right. So should we mark it as draft then to prevent accidental merging of this PR

we could, but some clarifications, doesn't "draft" mean that the work for the individual PR is not finished?
the case here is that for deployments PR is finished, but we need to updated other repos

@andreivladbrg andreivladbrg marked this pull request as draft October 9, 2024 14:24
@smol-ninja
Copy link
Member

As per https://github.blog/news-insights/product-news/introducing-draft-pull-requests/, Draft PR can be used to send various signals one of which is to block merging the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Think of a way to merge the core and periphery dirs
2 participants