Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling ssh-config of multi-vm files #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

megamisan
Copy link

@megamisan megamisan commented Nov 17, 2023

When using a Vagrantfile with multiple declared machines, saved ssh-config is wrong.

Currently, this call is done: vagrant ssh-config --host #{hostname}. The host parameter tell Vagrant how to name the entry.
With machines db and app, and respective hostnames project-db and project-app, the result for each looks like:

# VAGRANT: hash (db) / uuid
Host project-db
  HostName 127.0.0.1
  User vagrant
  Port 2222
  […]
Host project-db
  HostName 127.0.0.1
  User vagrant
  Port 2201
  […]
# VAGRANT: hash (db) / uuid
# VAGRANT: hash (app) / uuid
Host project-app
  HostName 127.0.0.1
  User vagrant
  Port 2222
  […]
Host project-app
  HostName 127.0.0.1
  User vagrant
  Port 2201
  […]
# VAGRANT: hash (app) / uuid

Which does not work well.

To fix this, it is required to add the machine name to the ssh-config call. Which results to vagrant ssh-config --host #{hostname} #{name} and a clean ssh-config file :

# VAGRANT: hash (db) / uuid
Host project-db
  HostName 127.0.0.1
  User vagrant
  Port 2222
  […]
# VAGRANT: hash (db) / uuid
# VAGRANT: hash (app) / uuid
Host project-app
  HostName 127.0.0.1
  User vagrant
  Port 2201
  […]
# VAGRANT: hash (app) / uuid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant