Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add extended support, supports uuid and naivedatetime #129

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mvntainer
Copy link

This is behind a feature crate, not sure how well is this implemented since I've never actually developed crates, please merge if you find this useful, you can also get the code form my fork, modify whatever you want and commit from your account, I just want the features, thanks

@qutax
Copy link

qutax commented Aug 16, 2023

Note about adding chrono as (optional) dependency:
This would introduce a CVE and it is unclear if/when this will be resolved for chrono.

Instead, time, which is used by chrono itself, could be used directly as an alternative.

See also:

@mvntainer
Copy link
Author

Note about adding chrono as (optional) dependency: This would introduce a CVE and it is unclear if/when this will be resolved for chrono.

Instead, time, which is used by chrono itself, could be used directly as an alternative.

See also:

I'm pretty sure we don't call the code that is vulnerable here in any way, I agree with your concerns however other crates I use in my projects depend on chrono so I don't plan to change this, if you want you could change it, or suggest how to fix it, thank you!

@vthg2themax
Copy link
Collaborator

@mvntainer Could you instead use the Display functionality instead?
See the following:
#128

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants