Added a ?Sized constraint to T in Mutex<T>
#47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dirbaio
reviewed
Aug 17, 2024
| @@ -71,7 +71,7 @@ use core::cell::{Ref, RefCell, RefMut, UnsafeCell}; | |||
| /// [`std::sync::Mutex`]: https://doc.rust-lang.org/std/sync/struct.Mutex.html | |||
| /// [interior mutability]: https://doc.rust-lang.org/reference/interior-mutability.html | |||
| #[derive(Debug)] | |||
| pub struct Mutex<T> { | |||
| pub struct Mutex<T: ?Sized> { | |||
There was a problem hiding this comment.
you should add ?Sized in all the impl blocks too, like impl<T: ?Sized> Mutex<T>
There was a problem hiding this comment.
But the compiler throws errors because the impl of UnsafeCell<T> doesn't mark T as ?Sized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a
?Sizedconstraint toTinMutex<T>, allowing it to work with unsized types, such as trait objects.