feat/fix: add new Client builder method with an arbitrary timeout value & add new method for scantxoutset status

[luisschwab]

This PR fixes #361 by creating a new buider method for Client, namely new_with_custom_timeout(), that adds a new timeout parameter relative to new().

This was done mainly to allow RPCs that take longer than 15 seconds as defined in the rust-jsonrpc crate.

It's up to the user to define a sensible timeout value.

let client = Client::new_with_custom_timeout(
                     "127.0.0.1",
                     Auth::UserPass("satoshi".to_string(), "satoshi".to_string()),
                     500
).unwrap();

[0xB10C]

Concept ACK

In the past I've worked around this by building a custom client (see e.g. #211 (comment)). Having the option to do this directly from rust-bitcoincore-rpc would be nice.

[notmandatory]

utACK 8e8790f

[notmandatory]

Oops, sorry didn't mean to re-review this. @tcharding can you kick off the workflow so the tests run?

[tcharding]

CI was all green when I read your post above but I re-ran all tests for you as well.

[apoelstra]

Yeah, I kicked it a few hours ahead of you :).

[notmandatory]

Thanks guys for kicking off the build, all checks passing.

This is a pretty straight forward change, anything else you think it needs to be ready to merge? This is required for a new feature @luisschwab is working on for BDK to allow a wallet to sync with a pruned bitcoind node.

[tcharding]

I personally have completely given up on this repo, I don't know if or when @stevenroose will merge and/or release.

[notmandatory]

@tcharding if @stevenroose is up for it maybe can add write access for a BDK dev or two? This crate is one of our upstream dependencies so we'd like to help keep it up-to-date.

[tcharding]

Steven doesn't check GitHub notifications very often, you'll have more luck if you reach him on Signal or some other method. I would suggest that you would have more success if you:

1. Just fork this repo if you really want to use it
2. Write your own client using types from https://github.com/rust-bitcoin/rust-bitcoind-json-rpc/

(2) may require some effort but would likely be better in the long run IMO, that crate is in progress though, if you give me a list of the JSONRPC methods you guys use I can prioritise them. I'm actively hacking on it.