fix deprecations in the std::error::Error trait impl #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apoelstra
approved these changes
Jun 10, 2024
There was a problem hiding this comment.
ACK bc71734 these changes are fine, but note that this crate is in a larger state of disrepair -- see rust-bitcoin/rust-bitcoin#2777 -- though it would be good to clean up clippy and rustc warnings at least
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
causeis deprecated in favor ofsource, calls tocauseare redirected theredescriptionis also deprecated because it is generally uninformative (the return value lifetime is very restrictive), this is replaced by the Display trait (already implemented)