Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code optimisations and clippies fixes #325

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

wthrajat
Copy link

@wthrajat wthrajat commented Jan 9, 2024

As of Rust 2018, we do not require to declare this in order to use the library.

extern crate bitcoincore_rpc;

Also fixes various clippies to optimise code for better and run cargo fmt.

Signed-off-by: wthrajat <rajatkhanduri290102@gmail.com>
@tcharding
Copy link
Member

Hi, thanks for the contribution! There are too many different things going on in each patch for me to easily review. Can you please split up the patches so they do one thing only. FWIW overall the changes look good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants