Update jsonrpc to 0.14
#276
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apoelstra
approved these changes
Jan 30, 2023
|
I'm a bit surprised that we didn't PR to do this sooner. FYI the update to rust-jsonrpc caused some other issues: apoelstra/rust-jsonrpc#80 and apoelstra/rust-jsonrpc#79. Our current plan is to try to move from rust-jsonrpc's ad-hoc HTTP client to minreq ... but that is stalled on minreq having a set of feature flags that don't all compile, and those which do have different MSRVs, and they don't have their intentions documented, and I haven't taken the time to exhaustively test everything. |
|
Will wait for somebody else to ACK this, and maybe have more discussion, before merging. |
Merged
|
I think we want to jump to latest version |
RCasatta
added a commit
that referenced
this pull request
Nov 1, 2023
7053c8f Update MSRV to Rust 1.48.0 (Tobin C. Harding) Pull request description: This would allow us to upgrade the `jsonrpc` dep and get `minreq` support possibly alleviating the need for #276. Also required to use the latest `rust-bitcoin`. ACKs for top commit: RCasatta: utACK 7053c8f Tree-SHA512: f3e25dfc2e61cab4666ab0be47406282fbdaabe614d98715377a16ff472d89f5678fb1a29613ca43cf9b671194b21af2b69c15d52ccd7dc26c0b8ac573b898a5
tcharding
approved these changes
Nov 1, 2023
|
Can we merge this? I"ll do a separate PR for upgrading further. |
|
rust-jsonrpc has supported minreq in version v0.16.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates
jsonrpcto0.14.Reason: Apparently, apoelstra/rust-jsonrpc#67 was fixed by apoelstra/rust-jsonrpc#72, which was included in version
0.14.