-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DRAFT] Support Core 22 and 23 #229
base: master
Are you sure you want to change the base?
Conversation
I'm not sure why but to get this to run locally against Bitcoin Core v22 I had to add a 0 to the default args list when calling diff --git a/client/src/client.rs b/client/src/client.rs
index 6dc50d3..dc5ee1b 100644
--- a/client/src/client.rs
+++ b/client/src/client.rs
@@ -1142,7 +1142,7 @@ pub trait RpcApi: Sized {
) -> Result<json::GetTxOutSetInfoResult> {
let mut args =
[opt_into_json(hash_type)?, opt_into_json(hash_or_height)?, opt_into_json(use_index)?];
- self.call("gettxoutsetinfo", handle_defaults(&mut args, &[null(), null(), null()]))
+ self.call("gettxoutsetinfo", handle_defaults(&mut args, &[null(), 0.into(), null()]))
}
/// Returns information about network traffic, including bytes in, bytes out,
diff --git a/integration_test/run.sh b/integration_test/run.sh
index bb06cfd..c178a69 100755
--- a/integration_test/run.sh
+++ b/integration_test/run.sh
@@ -22,9 +22,12 @@ BLOCKFILTERARG=""
if bitcoind -version | grep -q "v0\.\(19\|2\)"; then
BLOCKFILTERARG="-blockfilterindex=1"
fi
+if bitcoind -version | grep -q "v2"; then
+ BLOCKFILTERARG="-blockfilterindex=basic"
+fi
FALLBACKFEEARG=""
-if bitcoind -version | grep -q "v0\.2"; then
+if bitcoind -version | grep -q "v0\.2\|v2"; then
FALLBACKFEEARG="-fallbackfee=0.00001000"
fi |
I tried testing against Bitcoin Core v23 as well. I'm not sure why the CI error is being generated.
When I run bitcoind manually, create a wallet, generate an address, and dump the private key, it works fine. |
9aa1ec2
to
c189056
Compare
Starting with Bitcoin Core v23, Bitcoin Core will create descriptor wallets by default. You can't dump private keys from descriptor wallets. See also https://bitcoin.stackexchange.com/a/113838/63817. I've made progress with 0xB10C@ab16de2 which is now stuck on
https://github.com/0xB10C/rust-bitcoincore-rpc/actions/runs/6047586720/job/16411328972#step:4:1395 The whole create_wallet tests seems a bit fragile. edit: see also #230. I missed this before. |
Builds on top of #228, which modifies an RPC call to conform to Core 22.0, but we're not testing that version.
This PR will let us see how the test suite performs on those new versions, including the changes from #228.