Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ZMQ interface for BitcoinD #150

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

bennyhodl
Copy link
Contributor

Create the ZMQ interfaces and expose them through BitcoinD

Moved this upstream because I created a utility for LND and needed to add a function to retrieve the ZMQ interface.

@bennyhodl
Copy link
Contributor Author

Bump @RCasatta

@RCasatta
Copy link
Collaborator

Thanks for the bump, I missed it.

Absolutely concept ack but I think we should add a config.enable_zmq or similar for enabling zmq which is false by default. My fear is using too many ports...

@bennyhodl
Copy link
Contributor Author

@RCasatta added an optional config. Can rebase if it looks good

@RCasatta
Copy link
Collaborator

RCasatta commented Jan 3, 2024

LGTM,
if you can squash and run cargo fmt

You can ignore CI error on windows, and also ignore clippy warnings.

@RCasatta
Copy link
Collaborator

RCasatta commented Jan 3, 2024

ACK f69adc1

@RCasatta RCasatta merged commit f69adc1 into rust-bitcoin:master Jan 3, 2024
16 of 17 checks passed
@bennyhodl bennyhodl deleted the zmq-interfaces branch January 3, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants