Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add empty <commands> to Mandos rules #126

Merged
merged 2 commits into from
Aug 14, 2023
Merged

Add empty <commands> to Mandos rules #126

merged 2 commits into from
Aug 14, 2023

Conversation

bbyalcinkaya
Copy link
Member

Added empty <commands> to reduce build times and memory usage.

@bbyalcinkaya bbyalcinkaya marked this pull request as ready for review August 14, 2023 08:29
=> transferTxAux(#address2Bytes(FROM), #address2Bytes(TO), VAL) ...
</k>
<commands> . </commands>
[priority(60)]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the priority still needed after you added an empty commands cell to the rule? (it may be, I don't know/remember why it was useful before)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is not necessary since we have #wait and #endWasm to switch between k, commands, and instrs, but I'm not sure either.

@rv-jenkins rv-jenkins merged commit 9feff4f into master Aug 14, 2023
4 checks passed
@rv-jenkins rv-jenkins deleted the optimize-build branch August 14, 2023 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants