Rename arenaAlloc to fix collision with GHC RTS
#992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goodlyrottenapple
approved these changes
Feb 22, 2024
Baltoli
added a commit
that referenced
this pull request
Feb 27, 2024
This fixes a rather unpleasant bug when using the C bindings from the Haskell backend, whereby [recent changes](https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=246462) to the dynamic loader on macOS break symbol lookup from dynamic libraries. The result of this change is that calls to the backend's `arenaAlloc` function were ending up in the Haskell RTS's function of the same name, meaning that we got garbage memory allocated all over the place. There's no sensible fix here other than to rename our function and avoid the collision by doing so.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a rather unpleasant bug when using the C bindings from the Haskell backend, whereby recent changes to the dynamic loader on macOS break symbol lookup from dynamic libraries.
The result of this change is that calls to the backend's
arenaAllocfunction were ending up in the Haskell RTS's function of the same name, meaning that we got garbage memory allocated all over the place. There's no sensible fix here other than to rename our function and avoid the collision by doing so.