Set %option 8bit in KOREScanner.l
#949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Confirmed that this fixes the issue; good catch @Scott-Guest! |
Baltoli
approved these changes
Jan 12, 2024
Baltoli
pushed a commit
that referenced
this pull request
Jan 15, 2024
Fixes #948 Flex does not directly support Unicode, but it does support `%option 8bit` where every 8-bit byte in the input stream is treated as a separate character. To fix #948, rather than escaping in the frontend then, we can just accept any byte sequence inside comments (in practice always UTF-8), allowing the original source text to be passed through unmodified. However, 8-bit mode also makes it so that `.` and negated character classes `[^bar]` accept non-ASCII bytes, which we sometime want to disallow, e.g., in string literals, so we need to update every such regex accordingly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #948
Flex does not directly support Unicode, but it does support
%option 8bitwhere every 8-bit byte in the input stream is treated as a separate character. To fix #948, rather than escaping in the frontend then, we can just accept any byte sequence inside comments (in practice always UTF-8), allowing the original source text to be passed through unmodified.However, 8-bit mode also makes it so that
.and negated character classes[^bar]accept non-ASCII bytes, which we sometime want to disallow, e.g., in string literals, so we need to update every such regex accordingly.