Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable clang-tidy miscellaneous checks #934

Merged
merged 4 commits into from
Dec 18, 2023
Merged

Enable clang-tidy miscellaneous checks #934

merged 4 commits into from
Dec 18, 2023

Conversation

Baltoli
Copy link
Contributor

@Baltoli Baltoli commented Dec 18, 2023

This PR enables the "miscellaneous" set of clang-tidy checks. Adopting these checks requires basically no changes to our code, but I've left the following checks disabled:

  • Disallowing recursion
  • Disallowing unused parameters with names (e.g. this check prefers T f(A, B) to T f(A a, B b) when a and b are unused).
  • Using public data members in classes; we do this in a few places and I think it's an acceptable decision.

As ever, happy to bikeshed but this shouldn't be a controversial one at all.

@Baltoli Baltoli changed the title Enable clang-tidy miscellanous checks Enable clang-tidy miscellaneous checks Dec 18, 2023
@Baltoli Baltoli marked this pull request as ready for review December 18, 2023 17:40
@rv-jenkins rv-jenkins merged commit 9967b97 into master Dec 18, 2023
7 checks passed
@rv-jenkins rv-jenkins deleted the clang-tidy-misc branch December 18, 2023 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants