Remove old interpreter input when running tests #864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Baltoli
requested review from
theo25,
dwightguth,
Scott-Guest,
Robertorosmaninho and
gtrepta
Scott-Guest
approved these changes
Oct 17, 2023
Merged
rv-jenkins
pushed a commit
that referenced
this pull request
Oct 18, 2023
Similarly to #864, this PR addresses a flaky test that can be left in an intermediate state between runs of the test suite. In this case, we solve the problem by cleaning up all old `io_log.txt` files _before_ the relevant test runs, rather than at the end.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a small change to the
litlines we use to run checks on interpreter output; currently they can receive partially stale input if the test suite has previously been run. The solution is simply to remove any old output from previous interpreter runs before we run them again.Fixes #863