Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add calls to va_copy and va_end to fix UB in sfprintf #850

Merged
merged 3 commits into from
Oct 2, 2023
Merged

Add calls to va_copy and va_end to fix UB in sfprintf #850

merged 3 commits into from
Oct 2, 2023

Conversation

Scott-Guest
Copy link
Contributor

Using the same va_list multiple times is UB, and we should call va_copy before each use instead. We also need to call va_end.

(Pulling this out from the #828 because it was reverted).

@Scott-Guest Scott-Guest self-assigned this Sep 30, 2023
@Scott-Guest Scott-Guest marked this pull request as ready for review October 1, 2023 11:21
@rv-jenkins rv-jenkins merged commit 0952940 into master Oct 2, 2023
6 checks passed
@rv-jenkins rv-jenkins deleted the vsnprintf branch October 2, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwightguth dwightguth dwightguth approved these changes

Assignees

@Scott-Guest Scott-Guest

Labels
automerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Scott-Guest @dwightguth @rv-jenkins