Replacing date/gdate with perl program #833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Robertorosmaninho
added
the
dependencies
Robertorosmaninho
requested review from
Baltoli,
dwightguth and
radumereuta
|
I can probably delete these lines as well: llvm-backend/nix/llvm-backend.nix Lines 31 to 32 in f3e2923 They were added in #797 to fix an issue of using gdate on MacOS Homebrew.
|
radumereuta
reviewed
Sep 12, 2023
|
Yes, Perl seems to be default in Ubuntu Focal (v5.30), Jimmy (v5.34), and MacOS 13 (v5.30)! |
radumereuta
approved these changes
Sep 12, 2023
|
Seems ok if we are reasonably sure perl is always present on a system. Otherwise could always add perl as a runtime dependency for the nix built package here: llvm-backend/nix/llvm-backend.nix Line 17 in f3e2923 |
Yes, those should be deleted |
rv-jenkins
pushed a commit
that referenced
this pull request
Dec 21, 2023
In #833 we changed from the built-in date command to perl for getting the system time in ms; this caused some weird interactions with the OS when installed via `kup`: runtimeverification/kup#80 This PR drops our use of `perl` and instead uses an equivalent `python3` command, which we already depend on when building the backend.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes runtimeverification/k#3610
This PR replaces the use of
dateandgdate, depending on the user system, to get the current timestamp in milliseconds with a simplePerlprogram to improve compatibility across Unix-like systems.This modification is needed due to the following:
datein MacOS is a FreeBSD version that doesn't support (return) timestamps in milliseconds as we need inllvm-kompile --profileintroduced by Add--profileoption tollvm-kompile#793.gdateisn't a default package nor a standalone package to be installed in MacOS. Instead, it's commonly installed withcoreutils. We do not want to ask our users to install allcoreutilswhen we only needgdatefrom it and to use it in an optional flag.python timeandbash ${EPOCHREALTIME}, but this was the simplest to use and with common default dependencies in Unix-like systems.