Feature flag for tests broken by opaque pointers #812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets up a small amount of testing infrastructure to allow us to mark a test as expectedly failing in the presence of LLVM 16+ opaque pointers, and applies that marker to the test in question.
Marking the test as
XFAILwill allow us to merge support for LLVM 16 without having to pull in a much larger change to fix #810, though that issue should also be fixed when we have time to do so. Because the code in question is related only to GDB support, and the problem is clear, I'm happy to leave it in an explicitly-marked broken state for the time being.